Skip to content

refactor(shortcuts): forge specific issue and pull request urls - #3255

Merged
afonsojramos merged 8 commits into
mainfrom
refactor/forge-specific-shortcut-urls
Sep 3, 2026
Merged

refactor(shortcuts): forge specific issue and pull request urls#3255
afonsojramos merged 8 commits into
mainfrom
refactor/forge-specific-shortcut-urls

Conversation

@setchy

@setchysetchy commented Sep 3, 2026

Copy link
Copy Markdown
Member

closes#3253

@setchy
refactor(shortcuts): forge specific issue and pull request urls
3efd1a4
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@github-actionsgithub-actionsBot added the refactor Refactoring of existing feature label Sep 3, 2026
@setchy
refactor(shortcuts): forge specific issue and pull request urls
660e19c
Signed-off-by: Adam Setch <adam.setch@outlook.com>
afonsojramos
afonsojramos requested changes Sep 3, 2026
View reviewed changes

@afonsojramosafonsojramos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee! I am loving the modularity that we are achieving. Have dropped a couple of URL fixes.

Comment threadsrc/renderer/utils/forges/gitea/adapter.ts Outdated
Comment threadsrc/renderer/utils/forges/gitea/adapter.ts Outdated
Comment threadsrc/renderer/utils/forges/gitlab/adapter.ts Outdated
Comment threadsrc/renderer/hooks/useShortcutActions.ts
Comment threadsrc/renderer/stores/useAccountsStore.ts
Comment threadsrc/renderer/utils/forges/bitbucket/adapter.ts Outdated
@setchy

setchy commented Sep 3, 2026

Copy link
Copy Markdown
MemberAuthor

Niceee! I am loving the modularity that we are achieving. Have dropped a couple of URL fixes.

it really is nice to have this flexibility.

One pattern that felt a little smelly in this PR was the double-passing of account

eg:

getAdapter(account).getIssuesUrl(account)

something to perhaps explore later on...

@sonarqubecloud

sonarqubecloudBot commented Sep 3, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@afonsojramos
afonsojramos merged commit 730f517 into mainSep 3, 2026
19 checks passed
@afonsojramos
afonsojramos deleted the refactor/forge-specific-shortcut-urls branch September 3, 2026 17:48
@github-actionsgithub-actionsBot added this to the Release 7.x.x milestone Sep 3, 2026
@github-actionsgithub-actionsBot mentioned this pull request Sep 3, 2026
Merged
@afonsojramosafonsojramos mentioned this pull request Sep 3, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramosafonsojramosafonsojramos approved these changes

Assignees

No one assigned

Labels

refactorRefactoring of existing feature

Milestone

Release 7.x.x

Development

Successfully merging this pull request may close these issues.

Gitlab: incorrect URLs for issues and merge requests shortcut buttons

2 participants

@setchy@afonsojramos