Skip to content

refactor(api): orderby reviews no longer supported#3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 1 commit into from
Sep 5, 2026
+11 −2
Merged

refactor(api): orderby reviews no longer supported #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/utils/forges/github/graphql/pull.graphql
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,7 @@ fragment PullRequestDetails on PullRequest {
}
}
}
reviews(last: $lastReviews, orderBy: { field: CREATED_AT, direction: ASC }) {
reviews(last: $lastReviews) {
totalCount
nodes {
...PullRequestReviewFields
Expand Down
11 changes: 10 additions & 1 deletion src/renderer/utils/forges/github/handlers/pullRequest.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -240,7 +240,16 @@ export function getPullRequestReviewers(
{ reviewer: GitifyPullRequestReviewer; submittedAt?: string | null }
>();

for (const review of reviews) {
// GitHub no longer guarantees the reviews connection is returned in creation
// order, so sort by submission time (oldest first) to make the "newest wins"
// selection below deterministic regardless of the connection ordering.
const sortedReviews = [...reviews].sort((a, b) => {
const at = a.submittedAt ?? '';
const bt = b.submittedAt ?? '';
return at < bt ? -1 : at > bt ? 1 : 0;
});

for (const review of sortedReviews) {
const user = review.author?.login;
if (!user) {
continue;
Expand Down