Uh oh!
There was an error while loading. Please reload this page.
fix(identity): show display names on CL/Issue timeline system events - #2170
Conversation
Lifecycle comments were embedding campsite public ids, and Close/Reopen/Edit rendered that raw text; resolve labels on write and strip actor prefixes in the UI.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:5fda580e23
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| link, | ||
| username, | ||
| Some(format!("{username} removed {to_remove:?}")), | ||
| Some(format!("{display} removed {to_remove:?}")), |
There was a problem hiding this comment.
When display_label_for_actor falls back to a real display name with spaces, this writes comments like Jane Doe removed [1], but the existing label/assignee renderers derive the action from conv.comment?.split(' ')[1] (LabelItem and AssigneeItem), so the timeline shows Doe instead of removed/added/assigned. This affects any actor whose resolved display label is not a single token; keep the persisted prefix parse-compatible or update those renderers to strip the actor/display prefix before reading the verb.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Lifecycle comments were embedding campsite public ids, and Close/Reopen/Edit rendered that raw text; resolve labels on write and strip actor prefixes in the UI.