Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 30, 2024. It is now read-only.
Add the productionOnly query parameter to search API - #383
Merged
Conversation
noahingh
commented
Mar 14, 2022
Comment on lines
+44
to
+49
| s.Join(p).OnP( | ||
| sql.And( | ||
| sql.ColumnsEQ(p.C(perm.FieldRepoID), s.C(deployment.FieldRepoID)), | ||
| sql.EQ(p.C(perm.FieldUserID), u.ID), | ||
| ), | ||
| ) |
MemberAuthor
There was a problem hiding this comment.
bugfix:
-- Returns deployments under the accessible repositoriesJOINON`perms`.`repo_id`=`deployments`.`repo_id`AND`perms`.`user_id`= ?
Comment on lines
+113
to
+116
| // Or search deployments that were created between the start time and the end time. | ||
| index.Fields("created_at", "status"), |
MemberAuthor
There was a problem hiding this comment.
Switch the fields to optimize the index
noahinghforce-pushed
the
enhance-search-api
branch
from
April 10, 2022 05:47
6c7767e to
1e18919Comparenoahingh
commented
Apr 10, 2022
Comment on lines
+105
to
+106
| From: from, | ||
| To: to, |
MemberAuthor
There was a problem hiding this comment.
Move the way converting the format into the store package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
productionOnlyparameter is added to the API to retrieve only the deployments for the production environment. Related #382