Skip to content

Mypy linting issue with Repo.clone_from and progress bar #2001

Description

@jdumas

Hi,

Consider the following example:

importrich.progressimportgitfromgitimportRepofromrich.consoleimportConsoleconsole=Console(log_path=False)
classGitProgressPrinter(git.RemoteProgress):
def__init__(self, progress, name):
super().__init__()
self.progress=progressself.name=nameself.task=progress.add_task(name)
defupdate(self, op_code, cur_count, max_count=None, message=""):
passdefmain():
withrich.progress.Progress(console=console) asprogress:
progress_bar=GitProgressPrinter(progress, "My Repo")
Repo.clone_from("url", "dir", progress=progress_bar, depth=1)

Using gitpython==3.1.44 and mypy==1.15.0, it shows the following message:

Image

Argument of type "GitProgressPrinter" cannot be assigned to parameter "progress" of type "CallableProgress" in function "clone_from"
Type "GitProgressPrinter" is not assignable to type "CallableProgress"
Type "GitProgressPrinter" is not assignable to type "(int, str | float, str | float | None, str) -> None"
"GitProgressPrinter" is not assignable to "None"

Can you help me understand what's wrong here? Missing typing info on the gitpython side?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions