Skip to content

Read conditional include - #1054

Merged
Byron merged 12 commits into
gitpython-developers:masterfrom
buddly27:read-conditional-include
Sep 4, 2020
Merged

Read conditional include#1054
Byron merged 12 commits into
gitpython-developers:masterfrom
buddly27:read-conditional-include

Conversation

@buddly27

@buddly27buddly27 commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Closing #1053

Read conditional includes as defined in:
https://git-scm.com/docs/git-config#_conditional_includes

@buddly27buddly27 mentioned this pull request Sep 3, 2020
Closed
@ByronByron added this to the v3.1.8 - Bugfixes milestone Sep 3, 2020
Byron
Byron requested changes Sep 3, 2020
View reviewed changes

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this issue. It's a fantastic display on how tests can be written, and I hope future PRs will have more of that.

I found two spots to look at or discuss, along with a lot of praise in the other comments.

Please let me know what you think.

Comment threadtest/test_config.py
Comment threadtest/test_config.py
Comment threadAUTHORS Outdated
Comment threadgit/config.py Outdated
Comment threadgit/config.py Outdated
Comment threadgit/config.py Outdated
@Byron
Byron merged commit 94bbe51 into gitpython-developers:masterSep 4, 2020
@Byron

Byron commented Sep 4, 2020

Copy link
Copy Markdown
Member

Fantastic, thanks a lot. I am going to create a new release soon!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ByronByronByron requested changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.8 - Bugfixes

Development

Successfully merging this pull request may close these issues.

2 participants

@buddly27@Byron