Skip to content

Find paths ignored in .gitignore - #1063

Merged
Byron merged 3 commits into
gitpython-developers:masterfrom
saroad2:find_ignored_path
Sep 29, 2020
Merged

Find paths ignored in .gitignore#1063
Byron merged 3 commits into
gitpython-developers:masterfrom
saroad2:find_ignored_path

Conversation

@saroad2

@saroad2saroad2 commented Sep 28, 2020

Copy link
Copy Markdown
Contributor

Using git check-ignore in order to find whether paths are ignored or not in .gitignore

Byron
Byron requested changes Sep 29, 2020
View reviewed changes

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you contribution!

The merge is just two minor changes away, with the option for a bigger change for correctness. The latter won't block a merge though in case there is no time for that.

Comment threadgit/repo/base.py
Comment threadgit/repo/base.py Outdated
Comment threadgit/repo/base.py Outdated
Byron
Byron requested changes Sep 29, 2020
View reviewed changes

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! I think that leaves just one tiny thing before it can be merged.
Thanks for bearing with me.

Comment threadgit/repo/base.py Outdated
@ByronByron added this to the v3.1.9 - Bugfixes milestone Sep 29, 2020
@Byron
Byron merged commit 60acfa5 into gitpython-developers:masterSep 29, 2020
@saroad2
saroad2 deleted the find_ignored_path branch September 29, 2020 06:24
@Byron

Byron commented Sep 29, 2020

Copy link
Copy Markdown
Member

Great, thanks again!

@saroad2

saroad2 commented Sep 29, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot for the merge!

When are you planning on releasing a new version to PyPi? I would like to use this new ability in one of my projects.

@Byron

Byron commented Oct 1, 2020

Copy link
Copy Markdown
Member

Version 3.1.9 was just published to PyPi. Cheers.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ByronByronByron requested changes

Assignees

No one assigned

Labels

None yet

Milestone

v3.1.9 - Bugfixes

Development

Successfully merging this pull request may close these issues.

2 participants

@saroad2@Byron