Uh oh!
There was an error while loading. Please reload this page.
Fix missing stderr when the progress parameter of _clone is None - #1224
Conversation
muggenhor
left a comment
There was a problem hiding this comment.
Thanks for finding this! I've created a unit test that fails without and succeeds with this change (also with only the the condition change as I suggested).
Uh oh!
There was an error while loading. Please reload this page.
Byron
commented
Apr 22, 2021
Are you able to push it into this PR? If not I would be happy to do that for you if you post it here. |
Byron
commented
Apr 22, 2021
Once approved by @muggenhor this one should be ready to merge. Looks good to me (as the tests are green :) even though without the fix they are not). |
Uh oh!
There was an error while loading. Please reload this page.
Try to fix#1221
The
to_progress_instancefunction will convertNonetoRemoteProgressinstance, so the lineif progress_checkedis True ifprogressparameter isNone.