Skip to content

Avoid spawning console windows when running from .pyw - #126

Merged
Byron merged 1 commit into
gitpython-developers:0.3from
boppreh:patch-1
Nov 17, 2014
Merged

Avoid spawning console windows when running from .pyw#126
Byron merged 1 commit into
gitpython-developers:0.3from
boppreh:patch-1

Conversation

@boppreh

Copy link
Copy Markdown
Contributor

I'm developing a small background application (Windows + PyQt) to track Git repositories.

The GitPython module works great, but when called from a windowless script (.pyw) each command spawns a console window. Those windows are empty and last only a second, but I think they should not be there at all.

I saw it was using Popen to call the git executable and added a shell=True parameter to avoid spawning those windows.

Be aware I haven't tested this on other machines or operating systems.

By adding `shell=True,` to the list of Popen parameters, we avoid spawning console windows when scripts call this method from a windowless (.pyw) Python script.
@Byron
Byron merged commit 3f277ba into gitpython-developers:0.3Nov 17, 2014
@Byron

Copy link
Copy Markdown
Member

I didn't test it on windows either, but made sure a shell is only enforced on windows now.
This could be an issue, as I don't remember having experienced this popup issue back in the days when testing on windows.

@ByronByron added this to the v0.3.3 milestone Nov 17, 2014
Byron added a commit that referenced this pull request Apr 8, 2015
... if it is not found. Previously, especially on windows, this wasn't
explicit.
Fixes#248, affects #126
@Byron

Byron commented Apr 8, 2015

Copy link
Copy Markdown
Member

Please note that with the release of v0.3.7, you will need to to set git.Git.USE_SHELL=True to get back to the same behaviour.
See related issue #248 for more information.

govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
…/dependabot/github_actions/actions/setup-python-6
Bump actions/setup-python from 5 to 6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@boppreh@Byron