Skip to content

Fix issue #41: repo.is_dirty() on empty repository with stashed files - #53

Closed
fcelda wants to merge 1 commit into
gitpython-developers:masterfrom
fcelda:fix-issue-41
Closed

Fix issue #41: repo.is_dirty() on empty repository with stashed files#53
fcelda wants to merge 1 commit into
gitpython-developers:masterfrom
fcelda:fix-issue-41

Conversation

@fcelda

Copy link
Copy Markdown
Contributor

No description provided.

@Byron

Byron commented Jun 7, 2012

Copy link
Copy Markdown
Member

Thanks for the fix.

However, without a test I will not be able to merge it in.
Please use nosetest to run the existing tests. You could add a new one which verifies your fix.

Thank you

@fcelda

Copy link
Copy Markdown
ContributorAuthor

The problem was that the tests didn't run on my machine, otherwise I would add the tests as well. Take a look at my previous comment on this: #41 (comment)

I do not remember what was the problem, I have never worked with nose before. But let me take a look again. ;-)

@Byron

Copy link
Copy Markdown
Member

Thank you !
I believe your fix is already implemented by now.

@ByronByron closed this Nov 19, 2014
govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
govtech42 pushed a commit to mirror81/GitPython that referenced this pull request Jul 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fcelda@Byron