Skip to content

Start fixing #525 Windows errors - #530

Merged
ankostis merged 8 commits into
gitpython-developers:masterfrom
ankostis:fixwin
Oct 14, 2016
Merged

Start fixing #525 Windows errors#530
ankostis merged 8 commits into
gitpython-developers:masterfrom
ankostis:fixwin

Conversation

@ankostis

@ankostisankostis commented Oct 12, 2016

Copy link
Copy Markdown
Contributor
  • git-daemon:
    • Use git-daemon PORT above 10k; on Windows all below need Admin rights.
    • Used relative daemon-paths with --base-pth.
    • Simplify git-daemon start/stop/ex-hanlding.
      +FIXED git-daemon @with_rw_and_rw_remote_repo():
    • "Polish" most remote & config urls, converting -->/.
    • test_base.test_with_rw_remote_and_rw_repo() PASS.
  • Remote:
    • test_remote: apply polish-urls on _do_test_fetch() checking function.
    • test_remote.test_base() now freezes on Windows! (so still hidden win_err).
      pump fetch-infos instead of GIL-reading stderr.
    • Push-cmd also keep (and optionally raise) any error messages.
  • cmd.handle_process_output() accepts null-finalizer, to pump completely
    stderr before raising any errors.
  • test: Enable TestGit.test_environment() on Windows (to checks stderr
    consumption).
  • util: delete unused absolute_project_path().
  • Control separately freezing TCs on Windows with git.util.HIDE_WINDOWS_FREEZE_ERRORS flag.

@codecov-io

codecov-io commented Oct 12, 2016

Copy link
Copy Markdown

Current coverage is 94.87% (diff: 95.34%)

Merging #530 into master will increase coverage by 0.01%

@@ master #530 diff @@
==========================================
Files 63 63 Lines 9634 9643 +9 Methods 0 0 Messages 0 0 Branches 0 0 ==========================================
+ Hits 9139 9149 +10 + Misses 495 494 -1 
Partials 0 0 

Powered by Codecov. Last update e316575...c8e914e

@ankostis
ankostisforce-pushed the fixwin branch 3 times, most recently from c6b0a0a to e6853d5CompareOctober 12, 2016 20:32
+ Do not abspath twice when contructing cloned repo.
+ Add `git.repo.base` logger.
+ Parse most remote & config-urls \-->/.
+ Used relative daemon-paths.
+ Use git-daemon PORT above 10k; on Windows all below need Admin rights.
+FIXED git-daemon @with_rw_and_rw_remote_repo():
+ test_base.test_with_rw_remote_and_rw_repo() PASS.
+ test_remote.test_base() now freezes! (so still hidden win_err)
+ repo_test: minor finally delete test-repos created inside this repo.
+ util: delete unused `absolute_project_path()`.
+ cmd: use DEVNULL for non PIPEs; no open-file.
+ TCs: some unitestize-assertions on base & remote TCs.
…d stderr
+ `handle_process_output()` accepts null-finalizer, to pump completely
stderr before raising any errors.
+ test: Enable `TestGit.test_environment()` on Windows (to checks stderr
consumption).
@ankostis
ankostisforce-pushed the fixwin branch 2 times, most recently from 003b02f to 01751aaCompareOctober 13, 2016 23:04
@ankostisankostis changed the title Start fixing some #525 Windows errorsCygwin support & Start fixing #525 Windows errorsOct 14, 2016
+ Bug discovered after enabling TC in prev commit and rework of fetch.
+ remote_tc: unitestize assertions.
+ util: DEL unused `_mktemp()`.
@ankostisankostis changed the title Cygwin support & Start fixing #525 Windows errorsStart fixing #525 Windows errorsOct 14, 2016
…ions
+ Ignore `with_extended_output` arg when reaising the exception, keep
its behavior when `status==0`.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants

@ankostis@codecov-io@Byron