Skip to content

Configurable chunk size - #681

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
bpiotr:configurable-chunk-size
May 18, 2018
Merged

Configurable chunk size#681
Byron merged 1 commit into
gitpython-developers:masterfrom
bpiotr:configurable-chunk-size

Conversation

@bpiotr

Copy link
Copy Markdown
Contributor

Fixes#648

@Byron

Byron commented Oct 4, 2017

Copy link
Copy Markdown
Member

Thanks a lot! I am loving the tests, too!

I would happily merge it, it’s just flake8 having some silly white-space issue: https://travis-ci.org/gitpython-developers/GitPython/jobs/282786566#L1047 .

@alexandernst

Copy link
Copy Markdown

This is still not merged because of a single whitespace at the end of line 647. @bpiotr can you fix it or give me push permissions to your repo so I can push the fix there?

@codecov-io

codecov-io commented May 16, 2018

Copy link
Copy Markdown

Codecov Report

Merging #681 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #681 +/- ##
==========================================
+ Coverage 94.67% 94.67% +<.01% 
==========================================
Files 59 59 Lines 9310 9322 +12 ==========================================
+ Hits 8814 8826 +12 
Misses 496 496
Impacted FilesCoverage Δ
git/test/test_repo.py97.87% <100%> (+0.04%)⬆️
git/cmd.py83.62% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e3b0e...d2c8074. Read the comment docs.

@bpiotr
bpiotrforce-pushed the configurable-chunk-size branch 2 times, most recently from beeb6e9 to 86eb7b5CompareMay 16, 2018 19:42
@bpiotr
bpiotrforce-pushed the configurable-chunk-size branch from 86eb7b5 to d2c8074CompareMay 16, 2018 19:52
@bpiotr

Copy link
Copy Markdown
ContributorAuthor

@alexandernst OK, it's fixed now.

@alexandernst

Copy link
Copy Markdown

@Byron can we merge this and make a release?

@Byron
Byron merged commit 7be3486 into gitpython-developers:masterMay 18, 2018
@Byron

Copy link
Copy Markdown
Member

Thanks a ton for your contribution! There is another PR in review (#755), and when done, a new release can be cut.

@ByronByron added this to the v2.1.10 - Bugfixes milestone May 18, 2018
@bpiotr
bpiotr deleted the configurable-chunk-size branch May 18, 2018 19:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bpiotr@Byron@alexandernst@codecov-io