Skip to content

git: index: base: use os.path.relpath - #744

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
efiop:master
Apr 4, 2018
Merged

git: index: base: use os.path.relpath#744
Byron merged 1 commit into
gitpython-developers:masterfrom
efiop:master

Conversation

@efiop

@efiopefiop commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Fixes#743

Signed-off-by: Ruslan Kuprieiev kupruser@gmail.com

@efiop
efiopforce-pushed the master branch 5 times, most recently from 97164b0 to 176474bCompareApril 3, 2018 13:30
@codecov-io

codecov-io commented Apr 3, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #744 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #744 +/- ##
==========================================
+ Coverage 94.66% 94.66% +<.01% 
==========================================
Files 59 59 Lines 9289 9298 +9 ==========================================
+ Hits 8793 8802 +9 
Misses 496 496
Impacted FilesCoverage Δ
git/index/base.py94.63% <100%> (-0.02%)⬇️
git/test/test_index.py96.49% <100%> (+0.06%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79a3f8...c554ab1. Read the comment docs.

Byron
Byron requested changes Apr 3, 2018
View reviewed changes

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for submitting the fix! There is only a minor issue preventing a merge.
Thanks for having a look.

Comment threadgit/test/test_index.py Outdated
repo = Mocked()
path = os.path.join(root, 'file')
index = IndexFile(repo)
index._to_relative_path(path)

@ByronByronApr 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an assertion missing? It looks like _to_relative_path returns the relative path, which is not verified here.

@efiopefiopApr 3, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Thank you, fixed in a new version.

@ByronByron added this to the v2.1.10 - Bugfixes milestone Apr 3, 2018
@efiop
git: index: base: use os.path.relpath
c554ab1
Fixesgitpython-developers#743
Signed-off-by: Ruslan Kuprieiev <kupruser@gmail.com>
@Byron
Byron merged commit 0857d33 into gitpython-developers:masterApr 4, 2018
@Byron

Byron commented Apr 4, 2018

Copy link
Copy Markdown
Member

Thanks a lot! Looking good!

@efiopefiop mentioned this pull request Apr 13, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ByronByronByron requested changes

Assignees

No one assigned

Labels

None yet

Milestone

v2.1.10 - Bugfixes

Development

Successfully merging this pull request may close these issues.

3 participants

@efiop@codecov-io@Byron