Skip to content

Update test_docs.py - #773

Merged
Byron merged 2 commits into
gitpython-developers:masterfrom
markrowsoft:patch-1
Jul 15, 2018
Merged

Update test_docs.py#773
Byron merged 2 commits into
gitpython-developers:masterfrom
markrowsoft:patch-1

Conversation

@markrowsoft

Copy link
Copy Markdown
Contributor

Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.

I had some co-workers end up using popen commands vs using this library when I recommended GitPython as they did not understand how it worked from skimming the docs.

Sorry for not writing a test that fails... only a syntax change for readability.

markrowsoftand others added 2 commits June 14, 2018 15:32
Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #773 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #773 +/- ##
==========================================
- Coverage 94.69% 94.69% -0.01% 
==========================================
Files 59 59 Lines 9353 9352 -1 ==========================================
- Hits 8857 8856 -1 
Misses 496 496
Impacted FilesCoverage Δ
git/test/test_docs.py100% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5dfe7...4fa116c. Read the comment docs.

@Byron
Byron merged commit 1ca25b9 into gitpython-developers:masterJul 15, 2018
@Byron

Copy link
Copy Markdown
Member

Thanks a lot for your contribution! Along with that other PR which fixes the indentation, the tutorial should be so much easier to read and understand.

@ByronByron added this to the v2.1.11 - Bugfixes milestone Jul 15, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@markrowsoft@codecov-io@Byron