Skip to content

Support multiple git config values per option - #829

Merged
3 commits merged into
gitpython-developers:masterfrom
ajdavis:multi-value
Jul 6, 2019
Merged

Support multiple git config values per option#829
3 commits merged into
gitpython-developers:masterfrom
ajdavis:multi-value

Conversation

@ajdavis

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Jan 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #829 into master will decrease coverage by 0.59%.
The diff coverage is 93.07%.

Impacted file tree graph

@@ Coverage Diff @@## master #829 +/- ##
=========================================
- Coverage 94.79% 94.19% -0.6% 
=========================================
Files 59 59 Lines 9600 9507 -93 =========================================
- Hits 9100 8955 -145 - Misses 500 552 +52
Impacted FilesCoverage Δ
git/test/test_config.py98.75% <100%> (+0.39%)⬆️
git/config.py91.5% <87.14%> (-1.05%)⬇️
git/test/test_util.py90.07% <0%> (-8.56%)⬇️
git/test/test_base.py96.42% <0%> (-2.44%)⬇️
git/objects/submodule/base.py92.89% <0%> (-1.61%)⬇️
git/test/lib/helper.py90.69% <0%> (-1.44%)⬇️
git/test/test_submodule.py97.89% <0%> (-1.36%)⬇️
git/objects/tree.py59.64% <0%> (-0.93%)⬇️
git/repo/base.py94.6% <0%> (-0.78%)⬇️
git/test/test_repo.py97.25% <0%> (-0.71%)⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6ca8c...4106f18. Read the comment docs.

@ajdavis

Copy link
Copy Markdown
ContributorAuthor

OK, this pull request is ready to review. I believe that the AppVeyor failures in Python 3 predate this patch. I think the Travis failure is because the Travis config doesn't know how to run "TestRemote.test_base" on a pull request.

@ByronByron added this to the v2.1.12 - Bugfixes milestone Jul 6, 2019
@ByronByron self-assigned this Jul 6, 2019
@Byron

Byron commented Jul 6, 2019

Copy link
Copy Markdown
Member

First of all: Sorry for the late reply! Thanks a ton for your contribution! I will merge it ASAP!

As you can imagine, maintenance of this repository is only sporadic, at best. However, if you are interested, I would love to make you a contributor in case you would like to look after it from time to time. I am usually available to make releases in a timely fashion per request.

@ghost
ghost merged commit 4106f18 into gitpython-developers:masterJul 6, 2019
@ajdavis

Copy link
Copy Markdown
ContributorAuthor

Thanks for merging! I appreciate your work on this project very much but I don’t want to be a regular contributor.

This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ajdavis@codecov-io@Byron