Uh oh!
There was an error while loading. Please reload this page.
allow calling index.add, index.move and index.remove with single items - #840
allow calling index.add, index.move and index.remove with single items#840MarcelBeining wants to merge 2 commits into
Conversation
added testing for it closes#813
MarcelBeining
commented
Feb 8, 2019
hm guys, I am not that into testing to understand why the tests failed in some environments, maybebe you can help me. =/ thanks The only thing I see is that in AppVeyor, the test fails when I try to remove the added file again from the index with |
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution! Indeed, tests usually fail for PRs, which doesn't make things easy for contributors - my apologies.
The new test added here seems to work, so I am optimistic it will be fine when merged.
There is some added code duplication which I believe can mostly be avoided, please see the line comments for details.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
codecov-io
commented
Sep 19, 2019
Codecov Report
@@ Coverage Diff @@## master #840 +/- ##
==========================================
- Coverage 94.79% 94.64% -0.15%
==========================================
Files 59 59 Lines 9600 9401 -199 ==========================================
- Hits 9100 8898 -202 - Misses 500 503 +3
Continue to review full report at Codecov.
|
Byron
commented
Sep 28, 2019
Thanks a lot for your contribution thus far ! |
added testing for it
closes#813