Skip to content

Fix setup.py and use of requirements files - #853

Closed
jeking3 wants to merge 1 commit into
gitpython-developers:masterfrom
jeking3:fix-setup-py
Closed

Fix setup.py and use of requirements files#853
jeking3 wants to merge 1 commit into
gitpython-developers:masterfrom
jeking3:fix-setup-py

Conversation

@jeking3

Copy link
Copy Markdown
Contributor

There were requirements scattered about in both setup.py and requirements.txt - this consolidated them all into requirements files. It also adds python 3.5 and 3.6 to the tests.

@codecov-io

codecov-io commented Mar 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #853 +/- ##
=======================================
Coverage 94.79% 94.79% =======================================
Files 59 59 Lines 9603 9603 =======================================
Hits 9103 9103 Misses 500 500
Impacted FilesCoverage Δ
git/cmd.py84% <100%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f66e25...e219f15. Read the comment docs.

@jeking3

Copy link
Copy Markdown
ContributorAuthor

@Byron is it important to maintain support for Python 3.4? It doesn't understand some of the setup.py changes. I could mark the project as requiring Python 3.5 or later. This PR adds 3.6 and 3.7 testing to appveyor and it consolidates all the requirements logic for setup. Next PR will set some of the currently failing appveyor tests as allowed failures (miniconda variants). Thanks.

@jeking3jeking3 closed this May 5, 2019
@jeking3
jeking3 deleted the fix-setup-py branch May 5, 2019 18:02
@ByronByron added this to the v2.1.12 - Bugfixes milestone Jul 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jeking3@codecov-io@Byron