Uh oh!
There was an error while loading. Please reload this page.
use git rev-parse to look for config file - #894
Conversation
Byron
left a comment
There was a problem hiding this comment.
It looks like there is test breakage directly related to this commit.
Could you have a look?
Byron
commented
Jul 21, 2019
Thanks a lot for the contribution - I would love to merge, but can't as long as there is test breakage. Maybe it's an easy fix. |
bfc5263 to
946caf6Comparebdauvergne
commented
Jul 22, 2019
I tried a work-around but i'm not sure of it, there is some circular dependency between the search got the .git directory in Repo and the initialization of the self.git command wrapper (the git command should be able to find the .git itself, but the late initialization has maybe some use). |
14e53bf to
f45c70aComparebdauvergne
commented
Jul 22, 2019
And it works (I don't know the problem with appveyor, I do not think it's related to my patch). |
f45c70a to
7f12bd4Comparecodecov-io
commented
Jul 23, 2019
Codecov Report
@@ Coverage Diff @@## master #894 +/- ##
==========================================
- Coverage 93.6% 93.57% -0.03%
==========================================
Files 59 59 Lines 9769 9787 +18 ==========================================
+ Hits 9144 9158 +14 - Misses 625 629 +4
Continue to review full report at Codecov.
|
Byron
commented
Aug 11, 2019
Thanks so much! I am glad you could find the time. |
It fixes config file finding when in a separate worktree.
If fixes the issue with worktree reported in #719 (comment)