Skip to content

Remove assert that can fail erroneously. - #928

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
uri-canva:empty-progress
Sep 28, 2019
Merged

Remove assert that can fail erroneously.#928
Byron merged 1 commit into
gitpython-developers:masterfrom
uri-canva:empty-progress

Conversation

@uri-canva

@uri-canvauri-canva commented Sep 28, 2019

Copy link
Copy Markdown
Contributor

git will sometimes print out empty progress lines.

@ByronByron added this to the v3.0.3 - Bugfixes milestone Sep 28, 2019
@Byron

Byron commented Sep 28, 2019

Copy link
Copy Markdown
Member

Thanks a lot! I also wonder why these empty lines would be an issue, and since there is no test for that, the line might as well be removed.

@Byron
Byron merged commit 359a7e0 into gitpython-developers:masterSep 28, 2019
@uri-canva
uri-canva deleted the empty-progress branch September 28, 2019 13:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

v3.0.3 - Bugfixes

Development

Successfully merging this pull request may close these issues.

2 participants

@uri-canva@Byron