Uh oh!
There was an error while loading. Please reload this page.
Fixed#731 - #934
Conversation
Byron
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
That's an interesting issue as I was already posing the question if that's indeed a capability one would expect of GitPython, as opposed to the shell. Since it's acknowledged nonetheless and I the feature (probably) doesn't hurt, it's probably OK to merge it.
Something I think should be added in any case is support for the windows version of the home directory, something common seems %UserProfile%.
#731 also reveals that similar functionality was present at some point but seemingly removed. Without a test, this may happen here again. However, I would be OK to merge without a specific test.
Thanks a lot!
stsewd
commented
Oct 11, 2019
As a more general solution we could use |
codecov-io
commented
Oct 16, 2019
Codecov Report
@@ Coverage Diff @@## master #934 +/- ##
=========================================
+ Coverage 93.47% 93.6% +0.12%
=========================================
Files 59 59 Lines 9583 9804 +221 =========================================
+ Hits 8958 9177 +219 - Misses 625 627 +2
Continue to review full report at Codecov.
|
Byron
commented
Oct 17, 2019
Thanks a lot! This will work! |
Added check for local file
urlstarting with$HOME/~to expand them usingos.path.expanduser.