Skip to content

Fix/deepsource issues - #952

Merged
Byron merged 13 commits into
gitpython-developers:masterfrom
imkaka:fix/deepsource-issues
Oct 29, 2019
Merged

Fix/deepsource issues#952
Byron merged 13 commits into
gitpython-developers:masterfrom
imkaka:fix/deepsource-issues

Conversation

@imkaka

@imkakaimkaka commented Oct 23, 2019

Copy link
Copy Markdown
Contributor
  • Covers all critical issues.
  • Some Major issues also.

I will continue with this further.

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your continued contribution to this project.

Even though I would love to merge, I think it's more important to not break the interface than to satisfy deepsource. Thus I would be great if there could be another solution. Thank you.

Comment threadgit/refs/log.py Outdated
Comment threadgit/refs/log.py Outdated
@ByronByron added this to the v3.0.5 - Bugfixes milestone Oct 24, 2019
@imkaka
imkaka requested a review from ByronOctober 24, 2019 16:03

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot for fixing the issue found in first review, your continued effort is much appreciated.

Now it looks like there is only one small fix to be made and conflicts to be resolved before it can be merged.

Comment threadgit/refs/log.py
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #952 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #952 +/- ##
==========================================
+ Coverage 93.52% 93.53% +0.01% 
==========================================
Files 59 59 Lines 9677 9680 +3 ==========================================
+ Hits 9050 9054 +4 + Misses 627 626 -1
Impacted FilesCoverage Δ
git/cmd.py82.45% <ø> (ø)⬆️
git/objects/submodule/base.py92.89% <100%> (ø)⬆️
git/test/test_docs.py99.6% <100%> (ø)⬆️
git/refs/log.py93.12% <100%> (+0.05%)⬆️
git/exc.py96.42% <100%> (ø)⬆️
git/diff.py97.99% <100%> (+0.01%)⬆️
git/test/test_repo.py96.9% <0%> (+0.15%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa0eac...9932e64. Read the comment docs.

@imkaka
imkaka requested a review from ByronOctober 28, 2019 10:07

@ByronByron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! I can't wait to see deepsource happy one day :).

@Byron
Byron merged commit 9932e64 into gitpython-developers:masterOct 29, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@imkaka@codecov-io@Byron