Skip to content

Added parsing for '@1400000000 +0000' date format as used by git commit hooks - #965

Merged
Byron merged 1 commit into
gitpython-developers:masterfrom
dries007:parse_at_timestamp
Dec 29, 2019
Merged

Added parsing for '@1400000000 +0000' date format as used by git commit hooks#965
Byron merged 1 commit into
gitpython-developers:masterfrom
dries007:parse_at_timestamp

Conversation

@dries007

Copy link
Copy Markdown
Contributor

The git pre-commit hook is run with the GIT_AUTHOR_DATE environment variable set.
The format used (on my machine anyway) is @1574863356 +0100, which is not handles correctly by parse_date.

This PR fixes that crash, but it doesn't quite fully resolve issue #963. This issue also contains steps to reproduce and a stacktrace.

@ByronByron added this to the v3.0.6 - Bugfixes milestone Dec 29, 2019
@Byron

Copy link
Copy Markdown
Member

Apologies for the late response!
Thanks a lot for your contribution, it's much appreciated!

@Byron
Byron merged commit f7cff58 into gitpython-developers:masterDec 29, 2019
wip-sync referenced this pull request in NetBSD/pkgsrc-wip Mar 7, 2020
3.1.0
=====
* Switched back to using gitdb package as requirement
(`gitdb#59 <https://github.com/gitpython-developers/gitdb/issues/59>`_)
3.0.9
=====
* Restricted GitDB (gitdb2) version requirement to < 4
* Removed old nose library from test requirements
Bugfixes
--------
* Changed to use UTF-8 instead of default encoding when getting information about a symbolic reference
(`#774 <https://github.com/gitpython-developers/GitPython/issues/774>`_)
* Fixed decoding of tag object message so as to replace invalid bytes
(`#943 <https://github.com/gitpython-developers/GitPython/issues/943>`_)
3.0.8
=====
* Added support for Python 3.8
* Bumped GitDB (gitdb2) version requirement to > 3
Bugfixes
--------
* Fixed Repo.__repr__ when subclassed
(`#968 <https://github.com/gitpython-developers/GitPython/pull/968>`_)
* Removed compatibility shims for Python < 3.4 and old mock library
* Replaced usage of deprecated unittest aliases and Logger.warn
* Removed old, no longer used assert methods
* Replaced usage of nose assert methods with unittest
3.0.7
=====
Properly signed re-release of v3.0.6 with new signature
(See `#980 <https://github.com/gitpython-developers/GitPython/issues/980>`_)
3.0.6
=====
| Note: There was an issue that caused this version to be released to PyPI without a signature
| See the changelog for v3.0.7 and `#980 <https://github.com/gitpython-developers/GitPython/issues/980>`_
Bugfixes
--------
* Fixed warning for usage of environment variables for paths containing ``$`` or ``%``
(`#832 <https://github.com/gitpython-developers/GitPython/issues/832>`_,
`#961 <https://github.com/gitpython-developers/GitPython/pull/961>`_)
* Added support for parsing Git internal date format (@<unix timestamp> <timezone offset>)
(`#965 <https://github.com/gitpython-developers/GitPython/pull/965>`_)
* Removed Python 2 and < 3.3 compatibility shims
(`#979 <https://github.com/gitpython-developers/GitPython/pull/965>`_)
* Fixed GitDB (gitdb2) requirement version specifier formatting in requirements.txt
(`#979 <https://github.com/gitpython-developers/GitPython/pull/965>`_)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants

@dries007@Byron