Add a sort option popup to branch list view

[UUGTech]

This Pull Request fixes/closes#2129, #2024

It changes the following:

• show last commit date and last commit author on branchlist popup.
• make it possible to sort by branch name, last commit date, and last commit author.

I followed the checklist:

• I added unittests
• I ran make check without errors
• I tested the overall application
• I added an appropriate item to the changelog

Screen.Recording.2024-03-22.at.19.46.23.mov

[extrawurst]

Thanks for taking a go at this!

If you look at other popups like the options or search-in-log popup you will notice that the way we do these is: using the navigation cursors to pick an option instead of adding a bunch of new key bindings for each option uniquely. if you could convert this on to the same that would be awesome

[UUGTech]

Thank you for pointing that out.
Now, it works with navigation keys 😄

Screen.Recording.2024-03-25.at.13.26.57.mov

[Concelare]

Would it be possible to change this from an unwrap to an unwrap_or to protect from panics just incase

[extrawurst]

how is this even possible to pass CI?
checkout main.rs: #![deny(clippy::unwrap_used)]

[extrawurst]

wtf MappedLocalTime: https://docs.rs/chrono/latest/chrono/offset/type.MappedLocalTime.html

lets do earliest and then unwrap the Option with unwrap_or_else

[extrawurst]

I am also debating whether to store this DateTime<Local> instead inside of BranchInfo which should be fine as it is just twice as big as the i64 that we we do not have to do this mess everytime the screen renders

[extrawurst]

but at the least the unwrap needs to go

[UUGTech]

@extrawurst Sorry for the delay 🙇‍♂️
I updated according to your feedback and left some comments.

[extrawurst]

when sorting it should also keep the selection: right now it only keeps the same index selected which will mostly be a different branch when sorting changes.

the popup list entries should also not use a focused (bold) style, make it more in line with other popups (search, fuzzy find)

[UUGTech]

@extrawurst
Thank you for your review.

when sorting it should also keep the selection: right now it only keeps the same index selected which will mostly be a different branch when sorting changes.

Easier way to find new branch is required in #2129, also I think sorting is that kind of feature.
I thought keeping the selection makes it difficult. 🤔
I myself am not strongly attached to it, so If you still prefer to keep the selection, then I will do so.

the popup list entries should also not use a focused (bold) style, make it more in line with other popups (search, fuzzy find)

Thank you. I'll fix this.

[extrawurst]

I myself am not strongly attached to it, so If you still prefer to keep the selection, then I will do so.

yes please. the use case you describe is better fixed by providing quick scroll-to-top/bottom shortcuts like we also have in the commit log list view

[UUGTech]

Other popups are in a bold style

Which is better?
not bold:

bold:

Currently, branch_sort popup is in bold style. This is same with other popups.
If they should not be bold, I will fix all popups.

[UUGTech]

the use case you describe is better fixed by providing quick scroll-to-top/bottom shortcuts like we also have in the commit log list view.

I made an issue for this.

[extrawurst]

Other popups are in a bold style

Which is better? not bold: bold:

Currently, branch_sort popup is in bold style. This is same with other popups. If they should not be bold, I will fix all popups.

Let’s go non bold and make only the selection bold

[UUGTech]

updated the style of these popups

branch-sort popup

Screen.Recording.2024-05-01.at.12.24.21.mov

logs-search popup

Screen.Recording.2024-05-01.at.12.25.00.mov

fuzzy-find popup

[extrawurst]

@UUGTech are you still planning to push this over the finish line? will mark it as needs_work

[UUGTech]

I'm sorry, but at this time I don't plan to continue working on this. It's okay to mark it as needs_work 🙇‍♂️

[vztester94w]

This was amazing feature. IMO there is no real purpose for default "sort by name", git is for tracking change over time and should be default.