Rob varie 5 (perloppiù filtri avanzati) - #19
Merged
Merged
Conversation
…AjfFormRenderer The widget no longer extends AjfCoreFormRenderer: it injects the AjfFormRendererService directly and exposes the single field instance, so the template renders one ajf-field instead of looping over slides and flat nodes. Drops ~40 unused inherited members (page slider, toolbars, orientation, error navigation, addGroup/removeGroup) and a leftover debug console.log.
The input of the first text filter sits inside a scrollable card content whose actions bar overlays its bottom, and the material cypress config sets scrollBehavior to false: the click implied by cy.type() landed on another element, so the typed value never reached the app and the create filter button assertion timed out after 60s. Type with force: true and assert the resulting input value, so a lost keystroke fails on the spot instead of surfacing as a misleading failure on the button state. Cover the same button state in a unit test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…reate-filter button disabled on empty value
sara-gnucoop
approved these changes
Sep 2, 2026
sara-gnucoop
left a comment
Contributor
There was a problem hiding this comment.
revert a change to keep the create-filter button disabled on empty value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.