Checking dict keys fails

[kellrott]

In standard python

>>> x={"hello" : "world"}
>>> "hello" in x
True

In gpython

>>> x={"hello" : "world"}
>>> "hello" in x
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 FIXME line of source goes here
TypeError: "unsupported operand type(s) for iter: 'dict'"

[ncw]

Implementing __iter__ for dict is very useful.

However for in to be efficient we should be implementing __contains__

gpython/py/sequence.go

Lines 121 to 147 in 61059b4

	// SequenceContains returns True if obj is in seq
	func SequenceContains(seq, obj Object) (found bool, err error) {
	if I, ok := seq.(I__contains__); ok {
	result, err := I.M__contains__(obj)
	if err != nil {
	return false, err
	}
	return result == True, nil
	} else if result, ok, err := TypeCall1(seq, "__contains__", obj); ok {
	if err != nil {
	return false, err
	}
	return result == True, nil
	}
	var loopErr error
	err = Iterate(seq, func(item Object) bool {
	var eq Object
	eq, loopErr = Eq(item, obj)
	if loopErr != nil {
	return true
	}
	if eq == True {
	found = true
	return true
	}
	return false
	})

[drew-512]

suggest @sbinet close -- addressed in #65

[sbinet]

fixed w/ #65 .