Skip to content

__ne__ of set return NotImplemented - #110

Merged
ncw merged 2 commits into
go-python:masterfrom
HyeockJinKim:set
Oct 8, 2019
Merged

__ne__ of set return NotImplemented #110
ncw merged 2 commits into
go-python:masterfrom
HyeockJinKim:set

Conversation

@HyeockJinKim

Copy link
Copy Markdown
Contributor

if type of other is not set,
return NotImplemented

@HyeockJinKimHyeockJinKim changed the title __ne__ of sct return NotImplemented __ne__ of set return NotImplemented Sep 30, 2019
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #110 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #110 +/- ##
==========================================
+ Coverage 69.64% 69.84% +0.19% 
==========================================
Files 60 60 Lines 10810 10812 +2 ==========================================
+ Hits 7529 7552 +23 + Misses 2750 2726 -24 - Partials 531 534 +3
Impacted FilesCoverage Δ
py/set.go75% <100%> (+16.81%)⬆️
py/bool.go34.04% <0%> (+6.38%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17d7d...6aa008e. Read the comment docs.

@ncwncw mentioned this pull request Oct 1, 2019
@ncw

ncw commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

Thank you :-) I'll merge this now.

@ncw
ncw merged commit 1dceaf8 into go-python:masterOct 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HyeockJinKim@codecov-io@ncw