Skip to content

Implement set repr - #117

Merged
corona10 merged 6 commits into
go-python:masterfrom
xarus01:master
Oct 14, 2019
Merged

Implement set repr#117
corona10 merged 6 commits into
go-python:masterfrom
xarus01:master

Conversation

@xarus01

Copy link
Copy Markdown
Contributor

Fix#85

@codecov-io

codecov-io commented Oct 8, 2019

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.85%. Comparing base (33327c5) to head (12fe2c0).

Files with missing linesPatch %Lines
py/set.go85.71%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #117 +/- ##
==========================================
+ Coverage 72.84% 72.85% +0.01% 
==========================================
Files 60 60 Lines 11935 11949 +14 ==========================================
+ Hits 8694 8706 +12 - Misses 2708 2709 +1 - Partials 533 534 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment threadpy/tests/set.py
Comment threadbuiltin/testfile Outdated
Comment threadgo.mod Outdated

@corona10corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please resolve the conflict
  2. There are some codes that are not related to #85, please revert them.

Thank you :0

@xarus01
xarus01 requested a review from corona10October 10, 2019 09:10

@corona10corona10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10
corona10 merged commit 0c23b14 into go-python:masterOct 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement set repr

4 participants

@xarus01@codecov-io@sbinet@corona10