Uh oh!
There was an error while loading. Please reload this page.
builtin: Update builtin_all and builtin_any for Python3 - #15
Merged
Conversation
corona10force-pushed
the
gh-14
branch
2 times, most recently
from
August 30, 2018 06:34
bfeae97 to
c3410f1Comparecorona10
commented
Aug 30, 2018
CollaboratorAuthor
Codecov Report
@@ Coverage Diff @@## master #15 +/- ##
==========================================
- Coverage 64.43% 64.41% -0.03%
==========================================
Files 55 55 Lines 9772 9766 -6 ==========================================
- Hits 6297 6291 -6
Misses 3008 3008 Partials 467 467
Continue to review full report at Codecov.
|
sbinet
commented
Aug 30, 2018
Member
perhaps create a PR with only the appveyor stuff? |
corona10
commented
Aug 30, 2018
CollaboratorAuthor
@sbinet |
sbinet
commented
Aug 30, 2018
Member
it seems travis is in one of its bad days (it doesn't manage to find your commit...) could you rebase on top of the latest |
Update builtin_all and builtin_any for Python3 reference: - https://docs.python.org/3/library/functions.html#all - https://docs.python.org/3/library/functions.html#allFixes: go-python#14
corona10
commented
Aug 30, 2018
CollaboratorAuthor
@sbinet PTAL |
corona10
commented
Aug 31, 2018
CollaboratorAuthor
@ncw PTAL |
ncw
commented
Aug 31, 2018
Collaborator
I think that looks great now :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update builtin_all and builtin_any for Python3
reference:
Fixes: #14