Skip to content

better Int.abs() and test coverage - #156

Merged
sbinet merged 3 commits into
go-python:masterfrom
drew-512:add-abs-intmin
Feb 7, 2022
Merged

better Int.abs() and test coverage#156
sbinet merged 3 commits into
go-python:masterfrom
drew-512:add-abs-intmin

Conversation

@drew-512

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Feb 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #156 (3e7147a) into master (3068cb5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #156 +/- ##
==========================================
+ Coverage 74.55% 74.58% +0.02% 
==========================================
Files 64 64 Lines 11187 11186 -1 ==========================================
+ Hits 8341 8343 +2 + Misses 2297 2295 -2 + Partials 549 548 -1 
Impacted FilesCoverage Δ
py/int.go77.81% <100.00%> (+0.94%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3068cb5...3e7147a. Read the comment docs.

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the below nitpick.

Comment threadbuiltin/tests/builtin.py Outdated

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet
sbinet merged commit cd69d37 into go-python:masterFeb 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@drew-512@sbinet