Uh oh!
There was an error while loading. Please reload this page.
added examples and py utils - #159
Conversation
Codecov Report
@@ Coverage Diff @@## master #159 +/- ##
==========================================
- Coverage 74.40% 72.96% -1.44%
==========================================
Files 66 70 +4 Lines 11395 11647 +252 ==========================================
+ Hits 8478 8498 +20 - Misses 2351 2583 +232
Partials 566 566
Continue to review full report at Codecov.
|
sbinet
left a comment
There was a problem hiding this comment.
looks good.
but could we find a way to wire the examples into either a func ExampleXXX or func TestXXX scaffolding?
so everything is tested w/ go test ./...?
(I guess func TestXXX would be easier)
drew-512
commented
Feb 10, 2022
I had that thought as well. If I make the example's main optionally output to a file, in the TestXXX variant I could just compare that output against a known output as the test. How does that sound? |
sbinet
commented
Feb 10, 2022
yes, that, or have everything being compiled as part of the
|
drew-512
commented
Feb 11, 2022
How does this look? I'm not well versed in this sort of stuff, so lmk what I'm missing, thanks. |
drew-512
commented
Feb 11, 2022
@sbinet This works on my setup but it looks like I need help getting it work with CI here. |
it probably is coming from this: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
drew-512
commented
Feb 12, 2022
Sigh, so I guess windows needed to be exe.exe? I test for windows at runtime and append an ".exe"? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
Co-authored-by: Sebastien Binet <binet@cern.ch>
drew-512
commented
Feb 12, 2022
yay! |
No description provided.