Skip to content

proper example completeness - #164

Merged
sbinet merged 2 commits into
go-python:masterfrom
drew-512:improve-example-completeness
Feb 13, 2022
Merged

proper example completeness#164
sbinet merged 2 commits into
go-python:masterfrom
drew-512:improve-example-completeness

Conversation

@drew-512

Copy link
Copy Markdown
Contributor

added proper py.Context.Close() for completeness and added as test for examples/embedding

@codecov

codecovBot commented Feb 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #164 (9b3b8be) into master (01cbebd) will increase coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #164 +/- ##
==========================================
+ Coverage 72.86% 72.89% +0.03% 
==========================================
Files 71 71 Lines 11678 11682 +4 ==========================================
+ Hits 8509 8516 +7 + Misses 2600 2595 -5 - Partials 569 571 +2 
Impacted FilesCoverage Δ
examples/embedding/main.go0.00% <0.00%> (ø)
examples/embedding/mylib.module.go29.68% <0.00%> (-2.58%)⬇️
main.go15.62% <100.00%> (+2.72%)⬆️
py/module.go71.69% <0.00%> (ø)
modules/runtime.go54.88% <0.00%> (+5.26%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cbebd...9b3b8be. Read the comment docs.

@sbinet
sbinet merged commit 232eb8e into go-python:masterFeb 13, 2022
@drew-512
drew-512 deleted the improve-example-completeness branch February 17, 2022 02:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@drew-512@sbinet