Uh oh!
There was an error while loading. Please reload this page.
Improve some things around how errors are reported when parsing a file - #177
Conversation
Tatskaari
commented
Apr 22, 2022
Nice! Fixed the tests up. They pass locally now. |
sbinet
left a comment
There was a problem hiding this comment.
LGTM.
thanks for sticking with us.
could you send another PR against go-python/license adding yourself to the AUTHORS and/or CONTRIBUTORS file(s) ?
then I'll merge this one in.
thanks again.
sbinet
commented
Apr 22, 2022
there's one remaining error, though: |
sbinet
commented
Apr 22, 2022
needs go-python/license#17 |
Signed-off-by: Sebastien Binet <binet@cern.ch>
sbinet
commented
May 5, 2022
I took the liberty of fixing the last remaining error and pushing my changes, so I could merge this PR in :) thanks a lot. |
Codecov Report
@@ Coverage Diff @@## master #177 +/- ##
=======================================
Coverage 73.22% 73.22% =======================================
Files 72 72 Lines 11765 11765 =======================================
Hits 8615 8615 Misses 2568 2568 Partials 582 582
Continue to review full report at Codecov.
|
Tatskaari
commented
May 5, 2022
Oh so sorry! I got distracted and forgot to get back to this one. Thanks for that :) |
sbinet
commented
May 5, 2022
no worries :) |
Given the malformed input "/Users/jpoole/gpython/test.py":
Before:
After