Skip to content

gpython: use peterh/liner@v1.1.0 - #18

Merged
sbinet merged 2 commits into
masterfrom
go-mod-update
Aug 31, 2018
Merged

gpython: use peterh/liner@v1.1.0#18
sbinet merged 2 commits into
masterfrom
go-mod-update

Conversation

@sbinet

Copy link
Copy Markdown
Member

This CL bumps go.mod to use peterh/liner@v1.1.0.

Also really test Go modules by enabling GO111MODULE=on, only for master.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #18 +/- ##
=======================================
Coverage 64.52% 64.52% =======================================
Files 55 55 Lines 9746 9746 =======================================
Hits 6289 6289 Misses 3010 3010 Partials 447 447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c49d2...93db19b. Read the comment docs.

@sbinet
sbinet requested a review from corona10August 30, 2018 13:30
@corona10

Copy link
Copy Markdown
Collaborator

@sbinet Can you squash all your commits into the single commit?

@sbinet

Copy link
Copy Markdown
MemberAuthor

I could but these 2 commits really do 2 different things. related, but different.
I can send 2 PRs if you'd prefer.

@sbinet
sbinet merged commit ed3c651 into masterAug 31, 2018
@sbinet
sbinet deleted the go-mod-update branch August 31, 2018 13:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sbinet@codecov-io@corona10