Skip to content

py: implement input - #252

Merged
sbinet merged 7 commits into
go-python:mainfrom
aisk:input
Feb 25, 2026
Merged

py: implement input#252
sbinet merged 7 commits into
go-python:mainfrom
aisk:input

Conversation

@aisk

@aiskaisk commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Since liner takes over control of stdin in the REPL, an InputHook is added and registered in REPL mode, which will use liner to get the input instead of reading from stdin directly.

sbinet
sbinet reviewed Feb 20, 2026
View reviewed changes

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

I have a couple of comments, see below.
also, it'd be great to add tests for this.

thanks again.

Comment threadstdlib/builtin/builtin.go Outdated
Comment threadstdlib/builtin/builtin.go
Comment threadstdlib/builtin/builtin.go
Comment threadstdlib/builtin/builtin.go Outdated
Comment threadstdlib/builtin/builtin.go Outdated
sbinet
sbinet reviewed Feb 23, 2026
View reviewed changes

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nitpicks.

Comment threadpy/file.go Outdated
Comment threadpy/file.go Outdated
sbinet
sbinet approved these changes Feb 25, 2026
View reviewed changes

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks a lot.

@sbinet
sbinet merged commit 530fdbd into go-python:mainFeb 25, 2026
6 checks passed
@aisk
aisk deleted the input branch February 25, 2026 09:23
@aiskaisk mentioned this pull request Feb 25, 2026
Closed
@sbinet

sbinet commented Feb 25, 2026

Copy link
Copy Markdown
Member

Fixes #170.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbinetsbinetsbinet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aisk@sbinet