Skip to content

py: harden __import__ argument handling - #253

Merged
sbinet merged 4 commits into
go-python:mainfrom
aisk:fix-import-fromlist-assertions
Feb 27, 2026
Merged

py: harden __import__ argument handling#253
sbinet merged 4 commits into
go-python:mainfrom
aisk:fix-import-fromlist-assertions

Conversation

@aisk

@aiskaisk commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Fix#204

sbinet
sbinet reviewed Feb 25, 2026
View reviewed changes

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few little nitpicks.

Comment threadpy/import.go Outdated
Comment threadpy/import.go Outdated
Comment threadpy/import.go
aiskand others added 3 commits February 26, 2026 01:29
@aisk@sbinet
Update py/import.go
0e80160
Co-authored-by: Sebastien Binet <binet@cern.ch>
@aisk@sbinet
Update py/import.go
2719465
Co-authored-by: Sebastien Binet <binet@cern.ch>
@aisk
Apply the review comment
f8a9604
sbinet
sbinet approved these changes Feb 27, 2026
View reviewed changes

@sbinetsbinet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbinet
sbinet merged commit c324a9a into go-python:mainFeb 27, 2026
6 checks passed
@aisk
aisk deleted the fix-import-fromlist-assertions branch February 27, 2026 14:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbinetsbinetsbinet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'__import__' takes incorrect arguments crashing gpython

2 participants

@aisk@sbinet