Skip to content

Added __str__ and __repr__ plus missing properties - #31

Merged
ncw merged 2 commits into
go-python:masterfrom
raff:complex__str__
Oct 10, 2018
Merged

Added __str__ and __repr__ plus missing properties #31
ncw merged 2 commits into
go-python:masterfrom
raff:complex__str__

Conversation

@raff

@raffraff commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

Implement #30 and add missing properties and methods
(real, imag, conjgate).

Also added tests.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #31 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #31 +/- ##
==========================================
+ Coverage 64.86% 65.04% +0.18% 
==========================================
Files 55 55 Lines 10074 10091 +17 ==========================================
+ Hits 6534 6564 +30 + Misses 3079 3065 -14 - Partials 461 462 +1
Impacted FilesCoverage Δ
py/complex.go31.17% <100%> (+14.83%)⬆️
py/property.go14.28% <0%> (+14.28%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f66e54...5ea88b8. Read the comment docs.

@ncw

ncw commented Oct 10, 2018

Copy link
Copy Markdown
Collaborator

That looks great - thank you :-)

@ncw
ncw merged commit d05bbcc into go-python:masterOct 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@raff@codecov-io@ncw