Uh oh!
There was an error while loading. Please reload this page.
py: Fix errors are suppressed in generator comprehensions - #38
Conversation
corona10
commented
Nov 28, 2018
@ncw list(axforxinrange(10))Can you recommend the proper place? |
Codecov Report
@@ Coverage Diff @@## master #38 +/- ##
==========================================
- Coverage 65.25% 65.24% -0.02%
==========================================
Files 56 56 Lines 10148 10150 +2 ==========================================
Hits 6622 6622 - Misses 3064 3066 +2
Partials 462 462
Continue to review full report at Codecov.
|
@ncw PTAL |
ncw
left a comment
There was a problem hiding this comment.
It looks like you've found a good place for the test :-)
I put a few little changes inline.
The coverage of unit test does not relevant with this PR
I would have thought it would be pretty well covered.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sequence.Iterate does not handle exceptions. Iterate() should return error except StopIteration.
corona10
commented
Nov 28, 2018
@ncw |
ncw
commented
Nov 29, 2018
That looks great thanks :-) I'll merge it now. It might be worth reveiwing other calls to |
Sequence.Iterate does not handle exceptions.
Iterate() should return error except StopIteration.
Fixes: #32