Skip to content

py: Support __len__ of rangetype. - #40

Merged
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-39
Dec 26, 2018
Merged

py: Support __len__ of rangetype.#40
ncw merged 1 commit into
go-python:masterfrom
corona10:gh-39

Conversation

@corona10

Copy link
Copy Markdown
Collaborator

Fixes: #39

@corona10
corona10 requested a review from ncwDecember 24, 2018 15:47
@codecov-io

codecov-io commented Dec 24, 2018

Copy link
Copy Markdown

Codecov Report

Merging #40 into master will increase coverage by 0.46%.
The diff coverage is 84.61%.

Impacted file tree graph

@@ Coverage Diff @@## master #40 +/- ##
=========================================
+ Coverage 65.24% 65.7% +0.46% 
=========================================
Files 56 56 Lines 10150 10170 +20 =========================================
+ Hits 6622 6682 +60 + Misses 3066 3019 -47 - Partials 462 469 +7
Impacted FilesCoverage Δ
py/range.go75% <84.61%> (+75%)⬆️
py/arithmetic.go61.69% <0%> (+1.11%)⬆️
py/list.go10.05% <0%> (+1.18%)⬆️
py/function.go25.95% <0%> (+1.52%)⬆️
py/sequence.go23.65% <0%> (+3.22%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ea0a4...dafaabf. Read the comment docs.

@corona10

Copy link
Copy Markdown
CollaboratorAuthor

@ncw PTAL

ncw
ncw approved these changes Dec 26, 2018

@ncwncw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thank you :-)

@ncw
ncw merged commit 82240ed into go-python:masterDec 26, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@codecov-io@ncw