ci: build the landing page on pull requests too - #3
Merged
Merged
Conversation
The workflow ran only on pushes to main, so a pull request touching the
layout, the content or the Hugo version got no signal at all. This
repository has open dependency PRs whose checks read "no checks", which
is not the same thing as green and must not be merged as if it were.
Two changes, and only two:
- a pull_request trigger, so the existing build job runs on every PR;
- deploy is guarded by `if: push || workflow_dispatch`, so a pull
request stops after building and uploading the artifact and never
replaces what is served.
Verified before being applied rather than after: `hugo --minify` was run
locally against this site and against all 195 ungated landing pages, and
the CARDS IN THE PRODUCED HTML were counted, not just the exit status.
That distinction is not theoretical -- on go-filesystems.github.io, hugo
0.155.0 exits 0 and writes no page at all, so an exit-code-only check
would have called it fine. All 195 produced real content.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow ran only on pushes to main, so a pull request touching the layout, the content or the Hugo version got no signal at all. This repository has open dependency PRs whose checks read "no checks" — which is not the same thing as green, and must not be merged as if it were.
Two changes, and only two
pull_requesttrigger, so the existingbuildjob runs on every PR.deployis guarded byif: push || workflow_dispatch, so a pull request stops after building and uploading the artifact and never replaces what is served.Verified before being applied, not after
hugo --minifywas run locally against this site and against all 195 ungated landing pages — and the cards in the produced HTML were counted, not just the exit status.That distinction is not theoretical. On
go-filesystems.github.io, hugo 0.155.0 exits 0 and writes no page at all; an exit-code-only check would have called it fixed. All 195 produced real content, between 1 and 43 cards each.🤖 Generated with Claude Code