chore: modernize stack by vmaerten · Pull Request #5 · go-task/setup-task

vmaerten · 2026-02-08T08:16:02Z

Summary

Replace ESLint with oxlint for faster linting
Replace Jest with Vitest for testing
Upgrade @actions/core to v2
Add npm caching (cache: "npm") to all CI workflows
Use npm ci instead of npm install in CI and Taskfile
Remove tsconfig.eslint.json and ESLint-specific config files
Add .licensed.yml reviewed entries for packages detected as "other"
Ignore npmjs.com URLs in markdown link checks
Simplify npx calls in workflows (remove --package/--call patterns)

- Replace npm with pnpm - Replace Jest with Vitest - Replace ESLint with Oxlint - Update all GitHub Actions workflows to use pnpm - Update Taskfile.yml for new tools - Add retry mechanism for flaky network tests - Update all dependencies to latest versions

nock 14.x has different network interception behavior that causes downloads to abort even with enableNetConnect(). Tests now pass in ~2s instead of timing out. Also switch license cache from npm to pnpm source.

The pnpm source for the licensed tool doesn't work properly (doesn't detect licenses, wrong file paths). Reverting to npm which works correctly with the license cache. Changes: - Remove packageManager field from package.json - Replace pnpm with npm in Taskfile.yml - Remove pnpm/action-setup from all workflows - Regenerate license cache with npm source

Eliminates the Node 24 DEP0169 deprecation warning emitted at runtime by `typed-rest-client` (which still relies on `url.parse()` in its latest 2.3.0 release). `@actions/http-client` uses the WHATWG `new URL()` API and exposes an equivalent `HttpClient.getJson()` with the same `allowRetries` / `maxRetries` options, so retry behavior is preserved.

- @actions/core 2.0.1 -> 2.0.3 - @types/node 25.0.3 -> 25.6.0 - oxlint 1.36.0 -> 1.60.0 - prettier 3.7.4 -> 3.8.3 - semver 7.7.3 -> 7.7.4 - vitest 4.0.16 -> 4.1.4 nock kept at 13.x (see 400d08f).

Bumps (nock kept at 13.x, see 400d08f): - @actions/core 2 -> 3 - @actions/http-client 2 -> 4 - @actions/io 2 -> 3 - @actions/tool-cache 2 -> 4 - typescript 5 -> 6 - markdownlint-cli 0.47 -> 0.48 All @actions/* v3+/v4+ are ESM only, so the project follows suit: - package.json: `"type": "module"` - tsconfig.json: module/moduleResolution NodeNext, target es2022 - sources migrated from `import foo = require(...)` to `import * as foo` - `__dirname` replaced by `import.meta.dirname` in tests - ncc auto-detects ESM and produces an ESM bundle (`dist/index.js` drops from ~2.1MB to ~1.1MB thanks to tree-shaking) The action surface is unchanged: inputs/outputs are identical and the runner still executes `node dist/index.js`. Only internal format changes.

ESM-idiomatic style: `import { join } from "node:path"` instead of `import * as path from "path"`. Applies to node builtins (with the `node:` prefix) and to `@actions/*`, `semver`, `nock`. Two local vars in `getFileName` were renamed (`platform`/`arch` → `taskPlatform`/`taskArch`) to avoid shadowing the new named imports. No behavior change. Tests still 4/4 PASS, bundle unchanged in size.

- Reformat workflow YAML and src/installer.ts with prettier 3.8.3 (new formatting rules from the version bump). - Skip package-lock.json in codespell config to silence false positives on package names like `devlop` that collide with dictionary entries. - Refresh .licenses/npm cache to reflect the dependency tree after the ESM migration and majors bump. Obsolete transitive license files (typed-rest-client, tunnel sub-tree, qs/side-channel-*, etc.) removed; new cache produced by licensed 5.x in CI (artifact from run 24605756090). Pre-existing `npm:validate` failure left as-is (same failure on main: schemastore `nodemon.json` $ref unresolved, out of scope).

Replaces check-action-metadata, check-license, check-markdown, check-npm, check-npm-dependencies, check-prettier-formatting, check-tsconfig, check-typescript, spell-check, test-typescript, and test-integration with a single workflow running the same jobs in parallel. Simplifications: - One unified trigger (push, pull_request, weekly cron) instead of per-workflow path filters. For a project this size, always running the full suite is simpler than maintaining 11 distinct path lists. - Dropped the `run-determination` gate specific to the arduino release branches convention — not relevant to this fork. - Single check suite shown per PR/commit instead of 11. sync-labels-npm.yml left untouched (different trigger, independent).

Aligns with the rest of the oxc-based tooling (oxlint). - Replace `prettier` with `oxfmt` in devDependencies. - Taskfile: `general:format-prettier` -> `general:format`, now runs `npx oxfmt --write .`. - CI: `check-prettier` job -> `check-format` using `oxfmt --check .` directly (no more git-diff trick, oxfmt exits non-zero on drift). - `.prettierignore` kept under that name (oxfmt reads it by default as the default ignore file). - src/installer.ts reformatted by oxfmt (wider default print-width than prettier, collapses multi-line imports and function signatures that fit). - package.json re-ordered: oxfmt sorts the keyword list alphabetically and places top-level keys in a different order than prettier did. oxfmt is still 0.x so the defaults may shift before 1.0 — if that becomes disruptive we can pin an exact version and add an `.oxfmtrc.json` to freeze the style. Tradeoff: oxfmt only formats JS/TS/JSON (no YAML/Markdown). The workflow YAML files and CHANGELOG.md will remain as prettier left them until someone edits them by hand; no CI enforcement on those file types anymore.

The schemastore `package.json` schema references `nodemon.json` via `$ref` for the `scripts` property. Without that referenced schema passed via `-r` to ajv-cli, validation fails with: error: can't resolve reference https://json.schemastore.org/nodemon.json from id https://json.schemastore.org/package.json# This has been failing on main since a schemastore refresh. Fix by downloading the nodemon schema alongside the other 10 and passing it as a reference. Validation now succeeds with `package.json valid`.

Taskfile.dev migrated away from the docsify hash-routed URLs (`/#/...`) to plain paths. The old URLs hang with Status 0 in markdown-link-check, breaking CI. /#/ -> / /#/installation -> /installation/

The next release of this action will be v2 (Node 24 breaking change already documented in CHANGELOG). Update self-referential uses in CI and README examples accordingly. CONTRIBUTING.md release workflow left as-is — its v1/v2 example now matches the current upgrade in progress.

@v6

…trix - actions/checkout@v5 -> @v6 (ci.yml + sync-labels-npm.yml). - Remove Task 2.x (2.8.1) from integration tests. Task 2.x is years old, has no macOS arm64 build (requiring an exclude rule), and its archive layout differed from 3.x which made the extraction path fragile. - Replace with Task 3.50.0 (latest). Task dropped the "Task version: " prefix and h1 hash from `--version` output at some point, so the expected string is just the bare version number.

Every push to a branch with an open PR triggered two CI runs: one from the `push` event and one from the `pull_request` event. Restrict `push` to the main branch so PR branches only trigger a single run via `pull_request`, while merges to main still get validated.

Trade-off: PRs from forks won't be CI'd automatically — they'll need a manual re-push or the maintainer to push the branch into the main repo. For this project's contribution pattern that's acceptable; avoids double runs on every internal push.

vmaerten · 2026-02-08T08:16:02Z

Summary

Replace ESLint with oxlint for faster linting
Replace Jest with Vitest for testing
Upgrade @actions/core to v2
Add npm caching (cache: "npm") to all CI workflows
Use npm ci instead of npm install in CI and Taskfile
Remove tsconfig.eslint.json and ESLint-specific config files
Add .licensed.yml reviewed entries for packages detected as "other"
Ignore npmjs.com URLs in markdown link checks
Simplify npx calls in workflows (remove --package/--call patterns)