Uh oh!
There was an error while loading. Please reload this page.
deps: update goffi v0.6.0, gputypes v0.5.1, x/sys v0.47.0 - #22
Merged
Conversation
…0.42.0 → v0.47.0 - goffi v0.6.0: assembly-level errno capture, callback stack safety fix, zero-alloc FFI - Adapt to breaking change: CallFunction returns (syscall.Errno, error) - Fix all golangci-lint issues: errcheck on Buffer.Unmap(), os.Remove, variable shadowing - Update CHANGELOG.md, UPSTREAM.md
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallFunctionreturns(syscall.Errno, error)Changes
wgpu/loader_unix.go_, err := ffi.CallFunction(...)— handle new errno returnexamples/*.goBuffer.Unmap()errors, fix variable shadowinginternal/nativelib/_ = os.Remove()in error paths, nolint gosecsetup/setup.goCHANGELOG.mdUPSTREAM.mdTest plan
go build ./...— cleango vet ./...— cleangolangci-lint run ./...— 0 issuesgo test -run "TestABI|..." ./...— all pass