plotter: implement GlyphBoxer for plotter.Line#762

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

kortschak · 2023-04-04T09:21:25Z

It's worth taking a look at how this affects this file when zoomed in.

it seems like, for the green "pre-" step, the outer limit of the steps is now the outer shell of the black line.

I think I've convinced myself it's coming from an hysteresis effect stemming from the original width of the (vertical) line.
it only shows for vertical lines because, in the example, the p.Y.{Min,Max} are fixed and the glyph boxes won't change the data view range in y (as ymax=20 is quite larger than the biggest y value).
the effect is then coming from clipping the x/y-ranges (via padX in plot.go) + (probably) some floating point rounding errors.

-Original file line number
+Diff line change
@@ Expand Up @@
 	return XYRange(pts)
 }
+// GlyphBoxes implements the plot.GlyphBoxer interface.
+func (pts *Line) GlyphBoxes(plt *plot.Plot) []plot.GlyphBox {
+	r := 0.5 * pts.LineStyle.Width
+	rect := vg.Rectangle{
+ Min: vg.Point{
+ X: -r,
+ Y: -r,
+ },
+ Max: vg.Point{
+ X: +r,
+ Y: +r,
+ },
+	}
+	bs := make([]plot.GlyphBox, pts.XYs.Len())
+	for i := range bs {
+ x, y := pts.XY(i)
+ bs[i] = plot.GlyphBox{
+ X: plt.X.Norm(x),
+ Y: plt.Y.Norm(y),
+ Rectangle: rect,
+ }
+	}
+	return bs
+}
 // Thumbnail returns the thumbnail for the Line, implementing the plot.Thumbnailer interface.
 func (pts *Line) Thumbnail(c *draw.Canvas) {
 	if pts.FillColor != nil {
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ @@
 %%Creator gonum.org/v1/plot/vg/vgeps
 %%Title:
 %%BoundingBox: 0 0 100 100
-%%CreationDate: 2021-08-04 15:18:17.591742993 +0200 CEST m=+1.847419518
+%%CreationDate: 2023-04-04 10:48:21.077295032 +0200 CEST m=+5.571568072
 %%Orientation: Portrait
 %%EndComments
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
 	return XYRange(pts)
 }
+// GlyphBoxes implements the plot.GlyphBoxer interface.
+func (pts *Line) GlyphBoxes(plt *plot.Plot) []plot.GlyphBox {
+	r := 0.5 * pts.LineStyle.Width
+	rect := vg.Rectangle{
+ Min: vg.Point{
+ X: -r,
+ Y: -r,
+ },
+ Max: vg.Point{
+ X: +r,
+ Y: +r,
+ },
+	}
+	bs := make([]plot.GlyphBox, pts.XYs.Len())
+	for i := range bs {
+ x, y := pts.XY(i)
+ bs[i] = plot.GlyphBox{
+ X: plt.X.Norm(x),
+ Y: plt.Y.Norm(y),
+ Rectangle: rect,
+ }
+	}
+	return bs
+}
 // Thumbnail returns the thumbnail for the Line, implementing the plot.Thumbnailer interface.
 func (pts *Line) Thumbnail(c *draw.Canvas) {
 	if pts.FillColor != nil {
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ @@
 %%Creator gonum.org/v1/plot/vg/vgeps
 %%Title:
 %%BoundingBox: 0 0 100 100
-%%CreationDate: 2021-08-04 15:18:17.591742993 +0200 CEST m=+1.847419518
+%%CreationDate: 2023-04-04 10:48:21.077295032 +0200 CEST m=+5.571568072
 %%Orientation: Portrait
 %%EndComments
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
 	return XYRange(pts)
 }
+// GlyphBoxes implements the plot.GlyphBoxer interface.
+func (pts *Line) GlyphBoxes(plt *plot.Plot) []plot.GlyphBox {
+	r := 0.5 * pts.LineStyle.Width
+	rect := vg.Rectangle{
+ Min: vg.Point{
+ X: -r,
+ Y: -r,
+ },
+ Max: vg.Point{
+ X: +r,
+ Y: +r,
+ },
+	}
+	bs := make([]plot.GlyphBox, pts.XYs.Len())
+	for i := range bs {
+ x, y := pts.XY(i)
+ bs[i] = plot.GlyphBox{
+ X: plt.X.Norm(x),
+ Y: plt.Y.Norm(y),
+ Rectangle: rect,
+ }
+	}
+	return bs
+}
 // Thumbnail returns the thumbnail for the Line, implementing the plot.Thumbnailer interface.
 func (pts *Line) Thumbnail(c *draw.Canvas) {
 	if pts.FillColor != nil {
@@ Expand Down @@

Uh oh!

plotter: implement GlyphBoxer for plotter.Line#762

Uh oh!

plotter: implement GlyphBoxer for plotter.Line #762

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plotter: implement GlyphBoxer for plotter.Line#762

Uh oh!

plotter: implement GlyphBoxer for plotter.Line #762

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plotter: implement GlyphBoxer for plotter.Line#762

Uh oh!

plotter: implement GlyphBoxer for plotter.Line #762

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plotter: implement GlyphBoxer for plotter.Line#762

Uh oh!

plotter: implement GlyphBoxer for plotter.Line #762

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!