Uh oh!
There was an error while loading. Please reload this page.
all: remove descent padding from horizontal axis - #780
Merged
Conversation
kortschak
marked this pull request as draft
June 13, 2024 03:16
sbinet
previously approved these changes
Jun 13, 2024
kortschakforce-pushed
the
axis_padding
branch
2 times, most recently
from
June 13, 2024 08:38
007520f to
4f16279Comparekortschak
commented
Jun 13, 2024
MemberAuthor
There's a bunch of stuff that I'm working through fixing because we were assuming all testing on amd64. |
kortschakforce-pushed
the
axis_padding
branch
2 times, most recently
from
June 13, 2024 09:06
6710bc5 to
8a64747Comparekortschak
commented
Jun 13, 2024
MemberAuthor
@sbinet vg/vggio.TestCanvas appears to be failing in an OS version-dependent manner. |
kortschak
commented
Jun 13, 2024
MemberAuthor
Now it's only appveyor. I think I'm OK with that. |
kortschak
marked this pull request as ready for review
June 13, 2024 09:51
| X: 0.4124*c.R + 0.3576*c.G + 0.1805*c.B, | ||
| Y: 0.2126*c.R + 0.7152*c.G + 0.0722*c.B, | ||
| Z: 0.0193*c.R + 0.1192*c.G + 0.9505*c.B, | ||
| X: float64(0.4124*c.R) + float64(0.3576*c.G) + float64(.1805*c.B), |
Member
There was a problem hiding this comment.
Maybe add back the omitted leading 0.
MemberAuthor
There was a problem hiding this comment.
The joy of working remotely on a rpi.
sbinet
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look.
Fixes#779