Skip to content

Reworked to use gooddata-http-client 3.0.0 - #1218

Merged
zhabba merged 2 commits into
masterfrom
dp-GRIF-316-rework
Dec 3, 2025
Merged

Reworked to use gooddata-http-client 3.0.0 #1218
zhabba merged 2 commits into
masterfrom
dp-GRIF-316-rework

Conversation

@zhabba

Copy link
Copy Markdown
Contributor

Now using gooddata-http-client:3.0.0 thus
migrated to Apache Http5 Classic API
Http4 kept to be used by Sardine WebDAV client.

Signed-off-by: Dmitrii Puzikov <dmitrii.puzikov@gooddata.com>
@zhabba
zhabba requested a review from CopilotDecember 1, 2025 16:59

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the codebase to use gooddata-http-client:3.0.0, which involves upgrading from Apache HTTP 4 to Apache HTTP 5 Classic API. The changes are primarily code formatting and style improvements, with the actual HTTP client migration work happening in dependencies.

Key Changes:

  • Removal of trailing blank lines from numerous Java source files
  • Reorganization of import statements to follow standard ordering (external imports, then internal imports, then static imports)
  • Repositioning of methods within classes to improve organization
  • Formatting improvements for code readability

Reviewed changes

Copilot reviewed 293 out of 1032 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
Multiple warehouse model filesRemoved trailing blank lines and reordered imports
Multiple project model filesReordered imports, removed trailing blank lines, and repositioned methods
Multiple notification filesImport reorganization and trailing blank line removal
Multiple metadata filesImport reorganization, method reordering, and formatting cleanup
Multiple executeafm filesImport reorganization, javadoc formatting, and trailing blank line removal
Multiple connector filesMethod reordering, import cleanup, and trailing blank line removal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milandufekmilandufek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zhabba
zhabba merged commit 8e95e4d into masterDec 3, 2025
1 check passed
@zhabba
zhabba deleted the dp-GRIF-316-rework branch December 3, 2025 10:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zhabba@milandufek@jiri-staroba