Uh oh!
There was an error while loading. Please reload this page.
chore: regenerate api-client against staging - #1727
Merged
Merged
Conversation
Generated with `make api-client STAGING=1`
Important Review skippedToo many files! This PR contains 422 files, which is 272 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Pro+ to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (422)
You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #1727 +/- ##
=======================================
Coverage 79.15% 79.15% =======================================
Files 271 271 Lines 18794 18796 +2 =======================================
+ Hits 14876 14878 +2
Misses 3918 3918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hkad98
reviewed
Aug 11, 2026
Comment on lines
+11
to
+22
| # The generator collapses the `type` enums of NotificationChannelDestination's oneOf children | ||
| # into the last child's single value (IN_PLATFORM), so valid destinations of the other types | ||
| # fail client-side validation on both serialization and response parsing. Restore the full set. | ||
| NotificationChannelDestination.allowed_values[("type",)].update( | ||
| { | ||
| "WEBHOOK": "WEBHOOK", | ||
| "SMTP": "SMTP", | ||
| "DEFAULT_SMTP": "DEFAULT_SMTP", | ||
| "IN_PLATFORM": "IN_PLATFORM", | ||
| } | ||
| ) | ||
Contributor
There was a problem hiding this comment.
Could you please elaborate why is this change necessary? I do not see any update in gooddata_api_client.model.notification_channel_destination
ContributorAuthor
There was a problem hiding this comment.
The tests fail without it https://github.com/gooddata/gooddata-python-sdk/actions/runs/31482951615/job/93751911476?pr=1727.
gooddata-api-client/gooddata_api_client/model/declarative_notification_channel.py changed from DeclarativeNotificationChannelDestination to NotificationChannelDestination. They have different order of values in oneOf.
"oneOf": [
{
"$ref": "#/components/schemas/DefaultSmtp"
},
{
"$ref": "#/components/schemas/InPlatform"
},
{
"$ref": "#/components/schemas/Smtp"
},
{
"$ref": "#/components/schemas/Webhook"
}
]
"NotificationChannelDestination": {
"oneOf": [
{
"$ref": "#/components/schemas/Webhook"
},
{
"$ref": "#/components/schemas/Smtp"
},
{
"$ref": "#/components/schemas/DefaultSmtp"
},
{
"$ref": "#/components/schemas/InPlatform"
}
],
"type": "object"
},
Due to some bug only the last value is accepted, which now changed from Webhook to InPlatform.
okrcmaGDforce-pushed
the
okrc/cq-2783-regen
branch
from
August 11, 2026 10:36
31c1649 to
821b8c7CompareokrcmaGDforce-pushed
the
okrc/cq-2783-regen
branch
from
August 11, 2026 10:43
821b8c7 to
384754aComparehkad98
approved these changes
Aug 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated with
make api-client STAGING=1