Uh oh!
There was an error while loading. Please reload this page.
fix(lcm): Fixing invalid content type with version - #2091
Conversation
Warning Review limit reached
Next review available in:21 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThe project version changed from ChangesJSON response handling
JRuby image setup
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/gooddata/rest/connection.rb`:
- Around line 650-652: Update content_type_with_version so versioned
application/json content types are accepted without requiring charset=UTF-8;
retain the existing non-empty, JSON, and version checks so process_response
recognizes values such as application/json; version=1.
- Around line 650-652: Update content_type_with_version to return false when
content_type is nil before calling empty?, while preserving the existing
validation for non-nil content types.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e470b087-e4c8-4c37-9375-d9a5517ab8f1
📒 Files selected for processing (2)
VERSIONlib/gooddata/rest/connection.rb
Uh oh!
There was an error while loading. Please reload this page.
5ec681a to
71cc4a2Comparea6a0812 to
aa175aeCompareThere was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@DockerfileOldImage`:
- Around line 32-36: Update the JRUBY_VERSION value used by the RVM installation
to 9.2.20.1, then verify that RubyGems 3.1.6 and jruby-openssl BouncyCastle
activation remain functional. If the project must retain 9.2.20.0, document the
security exception and its justification near the version configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Uh oh!
There was an error while loading. Please reload this page.
ec72b2e to
395d7deCompare395d7de to
c41d676CompareUh oh!
There was an error while loading. Please reload this page.
yenkins
commented
Aug 12, 2026
LCM bricks image availableNew image
Next steps1. Tag the image with its major version
Or via gh CLI: 2. Register bricks to prod clusters |
yenkins
commented
Aug 12, 2026
LCM bricks image availableNew image
Next steps1. Tag the image with its major version
Or via gh CLI: 2. Register bricks to prod clusters |
Uh oh!
There was an error while loading. Please reload this page.
Jira: GRIF-987
Summary by CodeRabbit
Bug Fixes
application/jsoncontent types is parsed correctly.Chores