Skip to content

fix(lcm): Fixing invalid content type with version - #2091

Merged
hung-nguyen-hoang merged 2 commits into
masterfrom
GRIF-987
Aug 12, 2026
Merged

fix(lcm): Fixing invalid content type with version#2091
hung-nguyen-hoang merged 2 commits into
masterfrom
GRIF-987

Conversation

@hung-nguyen-hoang

@hung-nguyen-hoanghung-nguyen-hoang commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Jira: GRIF-987

Summary by CodeRabbit

  • Bug Fixes

    • Improved response handling so JSON data with versioned application/json content types is parsed correctly.
    • Helps prevent errors when processing valid JSON responses with content-type version information.
  • Chores

    • Updated the project version from 3.7.106 to 3.7.107.
    • Improved container setup to preserve reliable HTTPS gem fetching and compatibility with bundled RubyGems.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@hung-nguyen-hoang, you've reached your PR review limit, so we couldn't start this review.

Next review available in:21 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ae4136e-2273-4bcc-ab12-7dc0232bb4c9

📥 Commits

Reviewing files that changed from the base of the PR and between aa175ae and c41d676.

📒 Files selected for processing (1)
  • DockerfileOldImage
📝 Walkthrough

Walkthrough

The project version changed from 3.7.106 to 3.7.107. Response processing now accepts JSON content types with a version parameter. The JRuby Docker setup retains its bundled RubyGems version.

Changes

JSON response handling

Layer / File(s)Summary
Versioned JSON detection
lib/gooddata/rest/connection.rb
process_response now recognizes JSON content types with a version= parameter. A private helper performs the match.
Release version update
VERSION
The project version changed to 3.7.107.

JRuby image setup

Layer / File(s)Summary
Bundled RubyGems retention
DockerfileOldImage
The Docker build no longer updates RubyGems to version 3.3.26. Comments document the retained RubyGems version and its jruby-openssl and HTTPS gem-fetching requirements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit with ears held high,
Versioned JSON now hops by.
The JRuby gems stay snug and sound,
3.7.107 marks new ground.
Clean builds bounce around!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main functional change: fixing JSON content types that include a version parameter.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/gooddata/rest/connection.rb`:
- Around line 650-652: Update content_type_with_version so versioned
application/json content types are accepted without requiring charset=UTF-8;
retain the existing non-empty, JSON, and version checks so process_response
recognizes values such as application/json; version=1.
- Around line 650-652: Update content_type_with_version to return false when
content_type is nil before calling empty?, while preserving the existing
validation for non-nil content types.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e470b087-e4c8-4c37-9375-d9a5517ab8f1

📥 Commits

Reviewing files that changed from the base of the PR and between 9171f43 and 5ec681a.

📒 Files selected for processing (2)
  • VERSION
  • lib/gooddata/rest/connection.rb

Comment threadlib/gooddata/rest/connection.rb
@hung-nguyen-hoang
hung-nguyen-hoangforce-pushed the GRIF-987 branch 2 times, most recently from a6a0812 to aa175aeCompareAugust 11, 2026 09:47

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@DockerfileOldImage`:
- Around line 32-36: Update the JRUBY_VERSION value used by the RVM installation
to 9.2.20.1, then verify that RubyGems 3.1.6 and jruby-openssl BouncyCastle
activation remain functional. If the project must retain 9.2.20.0, document the
security exception and its justification near the version configuration.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 878f7ff4-027a-40ab-82a4-c6cf2d08304f

📥 Commits

Reviewing files that changed from the base of the PR and between 5ba048a and aa175ae.

📒 Files selected for processing (1)
  • DockerfileOldImage

Comment threadDockerfileOldImage
@hung-nguyen-hoang
hung-nguyen-hoangforce-pushed the GRIF-987 branch 2 times, most recently from ec72b2e to 395d7deCompareAugust 11, 2026 10:20

@zhabbazhabba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hung-nguyen-hoang
hung-nguyen-hoang added this pull request to the merge queueAug 12, 2026
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Aug 12, 2026
@hung-nguyen-hoang
hung-nguyen-hoang added this pull request to the merge queueAug 12, 2026
@yenkins

Copy link
Copy Markdown

LCM bricks image available

New image stable/lcm-bricks is available.

Version3.7.107
Build tag202608120727.295abb4d

Next steps

1. Tag the image with its major version
Run the LCM: Retag stable image to major version workflow dispatch:

  • Go to Actions → LCM: Retag stable image to major version → Run workflow
  • Set tag to 3.7.107
  • Leave dry-run unchecked and click Run workflow

Or via gh CLI:

gh workflow run lcm-stable-retag.yaml --repo gooddata/gooddata-ruby -f tag=3.7.107 -f dry-run=false

2. Register bricks to prod clusters
Once the retag completes, manually run the respective Rundeck job for each cluster: rundeck-sslauth.na.intgdc.com

@yenkins

Copy link
Copy Markdown

LCM bricks image available

New image stable/lcm-bricks is available.

Version3.7.107
Build tag202608120759.aa29f8eb

Next steps

1. Tag the image with its major version
Run the LCM: Retag stable image to major version workflow dispatch:

  • Go to Actions → LCM: Retag stable image to major version → Run workflow
  • Set tag to 3.7.107
  • Leave dry-run unchecked and click Run workflow

Or via gh CLI:

gh workflow run lcm-stable-retag.yaml --repo gooddata/gooddata-ruby -f tag=3.7.107 -f dry-run=false

2. Register bricks to prod clusters
Once the retag completes, manually run the respective Rundeck job for each cluster: rundeck-sslauth.na.intgdc.com

Merged via the queue into master with commit aa29f8eAug 12, 2026
29 of 30 checks passed
@hung-nguyen-hoang
hung-nguyen-hoang deleted the GRIF-987 branch August 12, 2026 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hung-nguyen-hoang@yenkins@zhabba@milandufek@jiri-staroba