Skip to content

feat: add missing visual cue for closing dialogs with Esc key - #11386

Merged
jacob314 merged 1 commit into
google-gemini:mainfrom
JayadityaGit:includeTheEsc
Oct 17, 2025
Merged

jacob314 merged 1 commit into
google-gemini:mainfrom
JayadityaGit:includeTheEsc

Conversation

@JayadityaGit

Copy link
Copy Markdown
Contributor

TLDR

Added a missing visual cue for dialogs that support closing with the Esc key but did not previously display any hint about it.

Testing Matrix

  🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

@JayadityaGit
JayadityaGit requested a review from a team as a code owner October 17, 2025 17:15
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @JayadityaGit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface by providing explicit visual guidance for closing dialogs. It integrates a clear 'Esc to close' instruction into the footer of various interactive dialogs, making the existing keyboard shortcut more discoverable and improving overall usability without altering the underlying functionality.

Highlights

  • Improved User Experience: Added a visual cue to several dialogs, informing users that they can close the dialogs using the 'Esc' key. This addresses a previously missing hint for an existing functionality.
  • UI Consistency: The instructional text for keyboard shortcuts has been updated across multiple dialog components to include the 'Esc to close' hint, ensuring a consistent user experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a visual cue (Esc to close) to dialogs that support closing with the Esc key. The changes involve modifying the text displayed in the AuthDialog, EditorSettingsDialog, PermissionsModifyTrustDialog, and ThemeDialog components, as well as updating the ThemeDialog snapshot tests to reflect the new text. I have added review comments for the identified issues.

Comment thread packages/cli/src/ui/auth/AuthDialog.tsx
@JayadityaGit

Copy link
Copy Markdown
Contributor Author

Hey Team,

When you get a chance, could you please add the hacktoberfest-accepted label to this PR?
That would be really helpful — thank you! 🙏

and also for this pr :- #11289

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
please wait for approval from Miguel as well before submitting.

@jacob314
jacob314 added this pull request to the merge queue Oct 17, 2025
Merged via the queue into google-gemini:main with commit 2b61ac5 Oct 17, 2025
19 checks passed
thacio added a commit to thacio/auditaria that referenced this pull request Oct 18, 2025
Millsondylan pushed a commit to Millsondylan/gemini-cli-1 that referenced this pull request Oct 19, 2025
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants