feat: add missing visual cue for closing dialogs with Esc key - #11386
Conversation
Summary of ChangesHello @JayadityaGit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user interface by providing explicit visual guidance for closing dialogs. It integrates a clear 'Esc to close' instruction into the footer of various interactive dialogs, making the existing keyboard shortcut more discoverable and improving overall usability without altering the underlying functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request adds a visual cue (Esc to close) to dialogs that support closing with the Esc key. The changes involve modifying the text displayed in the AuthDialog, EditorSettingsDialog, PermissionsModifyTrustDialog, and ThemeDialog components, as well as updating the ThemeDialog snapshot tests to reflect the new text. I have added review comments for the identified issues.
|
Hey Team, When you get a chance, could you please add the hacktoberfest-accepted label to this PR? and also for this pr :- #11289 |

TLDR
Added a missing visual cue for dialogs that support closing with the
Esckey but did not previously display any hint about it.Testing Matrix