Skip to content
This repository was archived by the owner on Mar 22, 2024. It is now read-only.

Remove maybe_linking check from afl-clang-fast - #80

Merged
jonathanmetzman merged 1 commit into
google:masterfrom
andreafioraldi:patch-1
Mar 24, 2020
Merged

Remove maybe_linking check from afl-clang-fast#80
jonathanmetzman merged 1 commit into
google:masterfrom
andreafioraldi:patch-1

Conversation

@andreafioraldi

Copy link
Copy Markdown
Contributor

Some targets needs to include afl-llvm-rt.o not only when linking, see google/fuzzbench#110.
This change seems to not break nothing in AFL++.

Some targets needs to include afl-llvm-rt.o not only when linking, see google/fuzzbench#110.
This change seems to not break nothing in AFL++.

@Dor1sDor1s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch! This looks good to me, but I'm not really familiar with this part, CC'd @jonathanmetzman@lszekeres who likely know more

@jonathanmetzmanjonathanmetzman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman
jonathanmetzman merged commit 3ef34c1 into google:masterMar 24, 2020
@Dor1s

Copy link
Copy Markdown
Contributor

Thanks for the review, @jonathanmetzman !

sthagen added a commit to sthagen/google-AFL that referenced this pull request Mar 28, 2020
Remove maybe_linking check from afl-clang-fast (google#80)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andreafioraldi@Dor1s@jonathanmetzman