Skip to content

Make AuthSession final and add a delegate protocol to intercept and provide custom errors - #224

Merged
mdmathias merged 17 commits into
masterfrom
mdmathias/no-longer-open
Mar 30, 2023
Merged

Make AuthSession final and add a delegate protocol to intercept and provide custom errors#224
mdmathias merged 17 commits into
masterfrom
mdmathias/no-longer-open

Conversation

@mdmathias

Copy link
Copy Markdown
Collaborator

This change is motivated by the fact that Swift classes (even @objc and NSObject subclasses) cannot themselves be subclassed in Objective-C. Thus, we need to provide some mechanism for GSI-iOS to receive, and potentially modify, errors before they are delivered to the clients. The delegate protocol added here is that solution.

@mdmathiasmdmathias added this to the 3.0.0 milestone Jan 19, 2023
@mdmathias
mdmathias requested a review from peteaJanuary 19, 2023 20:09
Comment threadGTMAppAuth/Sources/AuthSessionDelegate.swift Outdated
Comment threadGTMAppAuth/Sources/AuthSessionDelegate.swift Outdated
Comment threadGTMAppAuth/Sources/GTMAppAuthExternalError.swift Outdated
Comment threadGTMAppAuth/Sources/GTMAppAuthExternalError.swift Outdated
Comment threadGTMAppAuth/Sources/AuthSession.swift
@mdmathias
mdmathias merged commit ca86011 into masterMar 30, 2023
@mdmathias
mdmathias deleted the mdmathias/no-longer-open branch March 30, 2023 16:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mdmathias@petea@ch40w31